EmilienM
commented
3 years ago I'm holding it a bit, I just realized a potential issue, I'm digging this out.
Closed EmilienM closed 3 years ago
EmilienM
commented
3 years ago I'm holding it a bit, I just realized a potential issue, I'm digging this out.
EmilienM
commented
3 years ago @mdbooth this one is ready for review.
EmilienM
commented
3 years ago Approving again since nothing has changed since I last reviewed. Is the potential issue you mentioned earlier not relevant anymore?
this is ready to be merged I think. Thanks
EmilienM
commented
3 years ago I wonder if we might want to either make the 2 MTUs configurable, or discover the real MTU somehow and subtract the encapsulation overhead from that. However, until we find a reason to do that, this /lgtm
ack, I'll keep that in mind for later probably. Thanks.
Switch bridge MTU to 1400 if tunnels are being used. When using VXLAN tunnels between the bridges, it's important to set proper MTU because the Ethernet frame is being encapsulated in
Ethernet + IP + UDP + Overlay Header. This means that the Maximum Transmission Unit for the underlay needs to be adjusted to something close to 1400. Using 1400 is a safe number for now which should give up flexibility in using IPv4 and IPv6 in the future.Remove default value for tunnel_remote_ips in template The default value for tunnel_remote_ips is already sets in default vars, we don't want to duplicate it in the template.