Closed EmilienM closed 3 years ago
I tested it against real disks and also with the default (loop device) and it worked fine. I think this is good to go unless there are concerns about the gotchas in the commit message.
/lgtm
Looks good. Perhaps we should print a warning when ceph_devices
is set and we detect that we'll use cephadm to deploy ceph, to let the user know this variable WILL NOT be honored.
Looks good. Perhaps we should print a warning when
ceph_devices
is set and we detect that we'll use cephadm to deploy ceph, to let the user know this variable WILL NOT be honored.
done
Looks good. Perhaps we should print a warning when
ceph_devices
is set and we detect that we'll use cephadm to deploy ceph, to let the user know this variable WILL NOT be honored.done
Perhaps I've completely misunderstood the gotcha with ceph_devices
, but it seems to me that it's not used unless the environment uses ceph-ansible. In this case the warning you've added doesn't really address my concern. I want to avoid:
ceph_devices
like before and expecting it to work with cephadmceph_devices
is ignored with cephadm?)
Ceph has given up ceph-ansible and therefore TripleO had to remove its support going forward.
This patch will detect if ceph-ansible can still be used and if not it'll configure ceph using
cephadm
.From a user standpoint, dev-install still offers 3 options:
extra_heat_params
.In other words, this change is backward compatible except if you deployed Ceph with
ceph_devices
that are rotational; then no OSD will be deployed and cephadm will crash. In that case it's suggested to go with option 1 previously described, but dev-install maintainers don't suggest to install Ceph on these disks because of performance impact.