search

shiftstack / dev-install

13 stars 16 forks source link

prepare_host: add task to make sure persistent NIC is enabled #133

Closed EmilienM closed 3 years ago

EmilienM commented 3 years ago

It's possible that CentOS or RHEL images come with persistent NIC naming disabled and we don't want that because it'll cause random networking issues after reboots.

Let's make sure we remove that argument from the grub cmd and rebuild grub.

EmilienM commented 3 years ago

yes except that I'm not entirely sure that we don't need to reboot right after. but honestly we already reboot a few tasks later so I guess this is fine now.

mdbooth commented 3 years ago

Now that I think about it, this is presumably going to rename nics. So anywhere we refer to nic names is going to potentially break after this? Perhaps we do need that immediate reboot. Is that what you were thinking of?

EmilienM commented 3 years ago

Now that I think about it, this is presumably going to rename nics. So anywhere we refer to nic names is going to potentially break after this? Perhaps we do need that immediate reboot. Is that what you were thinking of?

yes exactly. I'll add a reboot, just to be safe.