network: adjustments for new NetworkManager

shiftstack / dev-install

13 stars 16 forks source link

network: adjustments for new NetworkManager #193

Closed EmilienM closed 1 year ago

EmilienM commented 2 years ago

Unfortunately, the stdout/stderr of nmstatectl has changed between RHEL 8 and RHEL 9 and we rely on it to find out the checkpoint path.

This patch will:

Use apply instead of set (it was deprecated).
On RHEL9, use stderr to find the checkpoint name, this is as reliable as the way we do on RHEL8. I'll probably break again at some point, so we have a task that check that the checkpoint variable is correctly set.

mdbooth commented 2 years ago

You sure you want to do that? If it still does checkpoints there will we a way to use the feature.

The advantage of doing a checkpoint is that if you don't commit it within the timeout it automatically rolls it back. This saved me a bunch of redeploys in development when I was working on the networking stuff. I'd be inclined to look harder for how to keep it working with the new version.

EmilienM commented 2 years ago

I agree about the advantage, but I haven't found out to get the checkpoint name in centos9, it's not in stdout anymore so we can't do like we do now and I haven't found any CLI which gives the name of the checkpoint...

EmilienM commented 1 year ago

I finally found a way to make this work and keeping the checkpoint. This was tested on RHEL 9.2 but not on RHEL 8. I'll have to do it.

EmilienM commented 1 year ago

Currently testing on RHEL 8.4.

EmilienM commented 1 year ago

tested on RHEL 8.4 and 9.2, it worked as expected.