Closed EmilienM closed 1 year ago
Some of us are currently testing it, I suggest that we wait for it to be merged.
Note that this brings backward incompatible changes to dev-install; so I produced a release today which will be usable for anyone who wants the default to work with 16.2 and RHEL 8.4.
I need to add support for NtpServer when using internal puddles. That's for Ceph; I'll explain in a next patchset, tomorrow.
@EmilienM Is it ready for review?
@EmilienM Is it ready for review?
Yes, I'm debugging something today but I'm not sure it involves dev-install.
This is ready for review, @gprocunier had some comments (offline) but I think this can be addressed on a separate PR.
/lgtm /hold if there is any extra test to perform
further fixes/improvements should come via another PR.
Thanks for the review, let's iterate.
ntp_server
parameter (with a safe default when not using RHSM) for deploying with a specific NTP.redhat_registry_credentials
is now a dict with mandatoryusername
andpassword
fields.ceph_devices
via LVM.