shiftstack / dev-install

13 stars 16 forks source link

:warning: Switch OSP default to 17.1 :warning: #216

Closed EmilienM closed 1 year ago

EmilienM commented 1 year ago
EmilienM commented 1 year ago

Some of us are currently testing it, I suggest that we wait for it to be merged.

Note that this brings backward incompatible changes to dev-install; so I produced a release today which will be usable for anyone who wants the default to work with 16.2 and RHEL 8.4.

EmilienM commented 1 year ago

I need to add support for NtpServer when using internal puddles. That's for Ceph; I'll explain in a next patchset, tomorrow.

MaysaMacedo commented 1 year ago

@EmilienM Is it ready for review?

EmilienM commented 1 year ago

@EmilienM Is it ready for review?

Yes, I'm debugging something today but I'm not sure it involves dev-install.

EmilienM commented 1 year ago

This is ready for review, @gprocunier had some comments (offline) but I think this can be addressed on a separate PR.

MaysaMacedo commented 1 year ago

/lgtm /hold if there is any extra test to perform

EmilienM commented 1 year ago

further fixes/improvements should come via another PR.

Thanks for the review, let's iterate.