This pull request includes changes to the CHANGES.md, Sora/PackageInfo.swift, and Sora/PeerChannel.swift files. The most important changes are aimed at aligning the version string of libwebrtc in the connect signaling message with Android. This involves adding branch-heads, removing the first character of the libwebrtc version in parentheses, and modifying the transmitted string.
Here are the key changes:
Version String Alignment:
CHANGES.md: Updated the change log to reflect the alignment of the libwebrtc version string in the connect signaling message with Android. This involves adding branch-heads, removing the first character from the libwebrtc version in parentheses, and changing the transmitted string from Shiguredo-build M122 (M122.1.0 6b419a0) to Shiguredo-build M122 (122.6261.1.0 6b419a0).
Sora/PeerChannel.swift: Modified the webRTCVersion string in the PeerChannel class to include the new branch-heads and to remove the first character from the libwebrtc version.
miosakuma
commented
5 months ago
修正内容
シグナリング connect で送信される libwebrtc の内容を Android にあわせました。
当初は branch-head の値が送信されていないことから始まりましたが、 最終的には Android の同項目と出力内容を合わせる対応としています。 Sora C++ SDK も () 内に M をつけていないのでそちらに合わせることにしました。
修正前 "libwebrtc":"Shiguredo-build M122 (M122.1.0 6b419a0)"
修正後 "libwebrtc":"Shiguredo-build M122 (122.6261.1.0 6b419a0)"
Sora Android SDK の出力内容 "libwebrtc": "Shiguredo-build M121 (121.6167.4.0 0f741da)"
確認した内容
This pull request includes changes to the
CHANGES.md,Sora/PackageInfo.swift, andSora/PeerChannel.swiftfiles. The most important changes are aimed at aligning the version string oflibwebrtcin theconnectsignaling message with Android. This involves addingbranch-heads, removing the first character of thelibwebrtcversion in parentheses, and modifying the transmitted string.Here are the key changes:
Version String Alignment:
CHANGES.md: Updated the change log to reflect the alignment of thelibwebrtcversion string in theconnectsignaling message with Android. This involves addingbranch-heads, removing the first character from thelibwebrtcversion in parentheses, and changing the transmitted string fromShiguredo-build M122 (M122.1.0 6b419a0)toShiguredo-build M122 (122.6261.1.0 6b419a0).Code Changes:
Sora/PackageInfo.swift: Addedbranch-headsto theWebRTCInfoenum.Sora/PeerChannel.swift: Modified thewebRTCVersionstring in thePeerChannelclass to include the newbranch-headsand to remove the first character from thelibwebrtcversion.