This pull request primarily focuses on fixing and improving the configuration of simulcastEnabled in the WrapperVideoEncoderFactory.shared instance. The changes include removing the dependency on Configuration.spotlightEnabled and ensuring that the simulcastEnabled value reflects the value set during the type: offer event.
Here are the key changes:
Changes to CHANGES.md:
Removed the condition that overwrites WrapperVideoEncoderFactory.shared.simulcastEnabled with the value of simulcast set during the type: offer event. This change addresses a bug where the simulcast value set during the type: offer event was not being reflected.
Removed Configuration.spotlightEnabled from the conditions that set WrapperVideoEncoderFactory.shared.simulcastEnabled. This was done because Configuration.spotlightEnabled is not a condition for enabling simulcast.
Changes to Sora/PeerChannel.swift:
Removed the setting of WrapperVideoEncoderFactory.shared.simulcastEnabled based on configuration.simulcastEnabled or configuration.spotlightEnabled == .enabled. The new code only sets simulcastEnabled based on configuration.simulcastEnabled. A comment was added suggesting that the setting of WrapperVideoEncoderFactory might not be necessary here because it is set when the type: offer message is received.
変更内容
WrapperVideoEncoderFactory.shared.simulcastEnabledの設定条件からConfiguration.spotlightEnabledを削除するConfiguration.spotlightEnabledはサイマルキャストを有効化するための条件ではないため削除するThis pull request primarily focuses on fixing and improving the configuration of
simulcastEnabledin theWrapperVideoEncoderFactory.sharedinstance. The changes include removing the dependency onConfiguration.spotlightEnabledand ensuring that thesimulcastEnabledvalue reflects the value set during thetype: offerevent.Here are the key changes:
Changes to
CHANGES.md:WrapperVideoEncoderFactory.shared.simulcastEnabledwith the value ofsimulcastset during thetype: offerevent. This change addresses a bug where thesimulcastvalue set during thetype: offerevent was not being reflected.Configuration.spotlightEnabledfrom the conditions that setWrapperVideoEncoderFactory.shared.simulcastEnabled. This was done becauseConfiguration.spotlightEnabledis not a condition for enabling simulcast.Changes to
Sora/PeerChannel.swift:WrapperVideoEncoderFactory.shared.simulcastEnabledbased onconfiguration.simulcastEnabledorconfiguration.spotlightEnabled == .enabled. The new code only setssimulcastEnabledbased onconfiguration.simulcastEnabled. A comment was added suggesting that the setting ofWrapperVideoEncoderFactorymight not be necessary here because it is set when thetype: offermessage is received.