search

shiiion / dolphin

Dolphin fork intended to give Metroid Prime Trilogy mouselook controls
Other
471 stars 44 forks source link

Fixed Prime 1 stop dash check in Restore Dashing mod #37

Closed UltiNaruto closed 3 years ago

UltiNaruto commented 3 years ago

It was treated as u32 although it was supposed to be treated as u8

SirMangler commented 3 years ago

I assume this is a fix to a small mistake but I'm not certain about what you mean by "should have been treated as a u8". Instructions are always 32 bits long, aka u32. The addresses you're supplying are 32bits long and like normal, written as u32. As for offsets, the size doesn't matter as long as it is no longer than 32 bits (or whatever size you're adding it to). The rest is just padded by zeros when stored alone.

UltiNaruto commented 3 years ago

That's what I meant : *(u32*)(CPlayer + 0x37c) => *(u8*)(CPlayer + 0x37c)

SirMangler commented 3 years ago

Oh I understand, I took it too literally. You meant the instruction was supposed to load a bit rather than a word. Silly me.