search

shiimizu / ComfyUI-PhotoMaker-Plus

PhotoMaker for ComfyUI
GNU General Public License v3.0
149 stars 14 forks source link

Conflict issue with the repository name. #9

Closed ltdrdata closed 5 months ago

ltdrdata commented 6 months ago

There is already an existing repository with the same name "ComfyUI-PhotoMaker."

https://github.com/ZHO-ZHO-ZHO/ComfyUI-PhotoMaker

This may cause confusion in the future in various ways. It is recommended to change the repository name.

Aamir3d commented 6 months ago

Seconded. Please change the repository name. I wanted to try out your repo too, but have not been able to because of conflicts.

shiimizu commented 6 months ago

I have that extension installed as reference. You can install both repos if you rename the folders. git clone https://github.com/ZHO-ZHO-ZHO/ComfyUI-PhotoMaker.git ComfyUI-PhotoMaker-ZHO I don't want to to change the repo name because this is the ComfyUI implementation, while the rest are wrappers over diffusers.

Aamir3d commented 6 months ago

Thanks - I already had that installed before, so I renamed your repo :-) . Looking forward to trying out your implementation.

hben35096 commented 6 months ago

Seconded. Please change the repository name. I wanted to try out your repo too, but have not been able to because of conflicts.

I'd also like to try it, do I need to download the model file for 38G now?

Aamir3d commented 6 months ago

Seconded. Please change the repository name. I wanted to try out your repo too, but have not been able to because of conflicts.

I'd also like to try it, do I need to download the model file for 38G now?

The Photomaker.bin is ~1GB

hben35096 commented 6 months ago

In the .cachehuggingfacehub directory, is there no need to cache RealVisXL_V3.0?