shiimizu / ComfyUI-TiledDiffusion

Tiled Diffusion, MultiDiffusion, Mixture of Diffusers, and optimized VAE
294 stars 21 forks source link

Tile controlnet uses the conditioning from the previous generation with TiledDiffusion #9

Open sjuxax opened 8 months ago

sjuxax commented 8 months ago

Have a workflow where the first generation works great, but then subsequent generations use the tile controlnet from the previous generation instead of the current one. This effect is not seen if I bypass the Tiled Diffusion node. Seems there's something strange in the caching/application of the conditioning. Using Advanced Controlnet nodes.

shiimizu commented 8 months ago

That shouldn't happen since I made the ControlNets reset whenever a sampler is run. Do you have a workflow I can test?

49RpK5dY commented 8 months ago

I get this sometimes as well but I was not able to reliably reproduce as it seems to happen rarely and seemingly random. Example with workflow: 20240122_115238 3450

In the example the previous picture (same prompt, just a different seed (3448) ) upscaled properly, but the next one took previous one for 3/4 tiles during the upscale. I'm pretty sure this bug happened even without controlnet a few times and probably started somewhere around 99c062d2c621ec617373d2ea08f0ab2cf5df70f8 or 195fed535d6a2cb01dc519e0f431a4325c65721a

addddd2 commented 8 months ago

I have same issue, then batch_size>1 I think it's a ComfyUI cache problem

weidai11 commented 8 months ago

I also had this issue after updating this extension today. Reverting to commit 76632f7ec7dec118f7009778e430e1aaa7c42dfd resolved the issue for me.

shiimizu commented 8 months ago

Okay, this issue should be fixed in https://github.com/shiimizu/ComfyUI-TiledDiffusion/commit/529a9ae578e52a29864aabbbb171508de5ef08cd

yiwangsimple commented 8 months ago

The workflow address you uploaded for the 4x zoom is not working, can you upload it again , I would like to test the effect of the flow of the Tucheng diagram, thank you!

shiimizu commented 8 months ago

The one in the readme? workflow.json

yiwangsimple commented 8 months ago

It's back up. Thanks again.