shiimizu / ComfyUI_smZNodes

Custom nodes for ComfyUI such as CLIP Text Encode++
GNU General Public License v3.0
190 stars 14 forks source link

CLIP Text Encode++ ignores clip patches from LoRAs #1

Closed pamparamm closed 1 year ago

pamparamm commented 1 year ago

I believe I've found an issue with current hijack implementation: model_hijack.hijack(clip) ignores clip patches applied by LoRAs. This affects all parsers except comfy and comfy++. You can verify this by changing strength_clip value in Load LoRA node, there will be no differences in output images.

pamparamm commented 1 year ago

Works after 0849072