shiimizu / ComfyUI_smZNodes

Custom nodes for ComfyUI such as CLIP Text Encode++
GNU General Public License v3.0
190 stars 14 forks source link

Not the same as A1111. #17

Closed za-wa-n-go closed 10 months ago

za-wa-n-go commented 10 months ago

I have tried with WebUI 1.6.0 and A1111parser and it does not seem to give the same results.

ComfyUI ComfyUI_00029_

WebUI 00003-156680208700286

za-wa-n-go commented 10 months ago
image image
za-wa-n-go commented 10 months ago

Soryyyy. I didn't check my explanation enough.

za-wa-n-go commented 10 months ago

Not the same, but something close was found.

Comfy ComfyUI_00031_

A1111 00004-156680208700286

Please let me know if there are more settings that can be brought together.

shiimizu commented 10 months ago

SDXL models default to -2 clip skip in A1111 and ComfyUI. Also, DPM2 Karras != DPM++ 2M Karras. In ComfyUI, DPM2 is dpm_2.

Here's an example using DPM++ 2M Karras:

|stable-diffusion-webui|A1111 parser| |:---:|:---:| | ![04393-156680208700286-beautiful scenery nature glass bottle landscape, , purple galaxy bottle,](https://github.com/shiimizu/ComfyUI_smZNodes/assets/54494639/ae9befaf-103a-492e-83a2-d970dddd128f) | ![ComfyUI_temp_pyoxy_00004_](https://github.com/shiimizu/ComfyUI_smZNodes/assets/54494639/bda0a9cf-4396-4241-9239-d15d90e2507b) | Workflows are in the images.

There also seems to be a bug in ComfyUI. I had to revert the following commits to get those results:

za-wa-n-go commented 10 months ago

Thank you! Is the comfy side aware of this bug?

shiimizu commented 10 months ago

Thank you!

You're welcome :)

Is the comfy side aware of this bug?

No, someone should report the bug.

Robson1970 commented 10 months ago

Found this https://github.com/comfyanonymous/ComfyUI/discussions/118

"Noise on ComfyUI is generated on the CPU while the a1111 UI generates it on the GPU. This makes ComfyUI seeds reproducible across different hardware configurations but makes them different from the ones used by the a1111 UI."

za-wa-n-go commented 10 months ago

thankyou! Now a1111 should also be able to select cpu.