search

shiimizu / ComfyUI_smZNodes

Custom nodes for ComfyUI such as CLIP Text Encode++
GNU General Public License v3.0
190 stars 14 forks source link

[CRITICAL BUG] Nodes can't be found anymore #27

Closed isben closed 9 months ago

isben commented 9 months ago

I noticed today (but it could be be the case since a few days) that none of the smzNodes appear in the ComfyUI nodes list when I try to add one. I update my ComfyUI almost daily and I noticed smzNodes were updated on several occasions recently. Also, when loading an image generated with the smzNodes, I get an error message saying the nodes were not found and they are displayed in red on the workflow. Though, the Comfy-Manager shows them installed and enabled.

DrJKL commented 9 months ago

I think this is probably related to https://github.com/jags111/efficiency-nodes-comfyui/issues/10

DrJKL commented 9 months ago

Yup, the changes in https://github.com/jags111/efficiency-nodes-comfyui/pull/12 and removing DDIM from __init__.py got the nodes to load properly.

DrJKL commented 9 months ago

It does fail at sampling time. Probably needs some more work to adjust to the recent comfyui sampling code changes.

isben commented 9 months ago

Thanks for the news. I, indeed, updated my Efficiency nodes to version 2 a couple days ago.

jags111 commented 9 months ago

I am checking for this and will add a possible feedback for same.. Thanks for pointing this out and will check if I am able to push the modifications through.

shiimizu commented 9 months ago

Should be fixed in https://github.com/shiimizu/ComfyUI_smZNodes/commit/c4988de4e812a9475c14349ff63c00d9253c02da

isben commented 9 months ago

I confirm my issues have been solved with the latest changes. Thanks to all for the prompt reaction.