search

shiimizu / ComfyUI_smZNodes

Custom nodes for ComfyUI such as CLIP Text Encode++
GNU General Public License v3.0
168 stars 12 forks source link

Fix compatibility with ComfyUI-Logic #39

Closed pamparamm closed 6 months ago

pamparamm commented 7 months ago

Using smZNodes along with ComfyUI-Logic throws ValueError: invalid literal for int() with base 10: 'a != b' in prompt_handler method. Since not every str in node inputs can be parsed into int, I believe we should replace isinstance with is_number check.

shiimizu commented 6 months ago

It seems like you tried to pass a string (a != b) as an int though? If so, that's how it should behave.

pamparamm commented 6 months ago

Looks like 8764926 has resolved this issue, I think I can close this PR