search

shiimizu / ComfyUI_smZNodes

Custom nodes for ComfyUI such as CLIP Text Encode++
GNU General Public License v3.0
190 stars 14 forks source link

prompt switching broken in the latest update #5

Closed MotorMan closed 12 months ago

MotorMan commented 12 months ago

it looks like the prompt switching was broken with the IT/s degradation fix from 4 days ago.
i was able to verify that the alternating prompt switching, [subject1|subject2|subject3] is no longer alternating, and instead appears to be as if the [|] characters were stripped (i haven't tested to see if that is the actual case or not) you can tell by the preview in the sampler no longer flashing between the subjects like before. now it's a solid-smooth gen.

attached is an example from a previous version i recorded to show what a good prompt switching looks like. ezgif com-video-to-gif (1)

hopefully this info will help, and if you have any questions, just let me know.

shiimizu commented 12 months ago

I can't seem to reproduce this. Can you post a workflow?

MotorMan commented 12 months ago

ComfyUI_00034_ here is the original workflow i used to make the gif above. the picture is also the actual final image, since right now i have the old node version in for testing. i'll post a pic of the new version in a few minutes. let me know if github strips the metadata from the png or not. you should be able to just drag/drop it to your comfyui to get the workflow. edit: below is the final pic on the not-working-prompt switching. it looks close, but it's basically the same as having both names placed in the prompt. visually it's not swapping the prompt like A1111 or the old version does. i think if i was to use something less-human to demonstrate this issue it would be better. i'll see if i can come up with a prompt that might help demonstrate the problem between the old ver and the new ver. and as always, thanks for your help! ComfyUI_00035_

MotorMan commented 12 months ago

ok i came up with a pretty good way to show the issue. prompt is "RAW Photograph, a [potato|soccer ball], outdoors," in the new version, all you get is a plain potato. and in the old version, it's clearly a nice mix between a soccer ball and a potato. here are example images(same seeds): ComfyUI_00039_ ComfyUI_00040_ really hope this helps! =)

shiimizu commented 12 months ago

Are you sure you're on the latest commit? Can you try re-installing the node?

MotorMan commented 12 months ago

now that is interesting. i know i was up-to-date on it before(i even checked manager to make sure), since the IT/s degradation was gone, and i had updated it via the manager. i went and deleted the folder, ran comfyui to verify it had the node missing, also noticed smZNodes was not available as a "install missing nodes" for some reason, but then closed it, and ran cmd, and git clone'd the repo to the custom nodes dir, and started comfyui again, and ran the test, and it's clearly prompt switching again. after pondering this a few min i think i might of gotten stuck on an in-between version. smZNodes is no longer showing up in manager as an available node or an installable one, so that may have gotten me stuck on the 8-21-23 11:18pm version. i'll have to check my other comfyui installs to make sure, but as of now, i think i'll call this good and the problem was comfyUI manager not updating the node. thanks again for your help! edit: a few hours later, i finally found the real cause. if you do not use the smZ CLIPTextEncode for both positive and negative, it will fail to prompt switch. and i had switched to 1 of smZ CLIPTextEncode and a default prompt for negatives. so that is why it looked like it was failing.