search

shiimizu / ComfyUI_smZNodes

Custom nodes for ComfyUI such as CLIP Text Encode++
GNU General Public License v3.0
190 stars 14 forks source link

Possible issue regarding parsers? #7

Closed LucianoCirino closed 11 months ago

LucianoCirino commented 11 months ago

Hello Shiimizu, while testing your nodes to attempt replicating A1111 images, I realized that when using your node with the parser on Comfy++ and mean normalization turned on, it semi-matches Blender Neko's node when his Parser is on A1111 with mean normilization also turned on.

workflow

Something seems off... Below is both on A1111 parser + mean normilization as True.

workflow (1)

Would appreaciate your help :)

Also I am aware of your quote in your FAQ:

How does this differ from [ComfyUI_ADV_CLIP_emb](https://github.com/BlenderNeko/ComfyUI_ADV_CLIP_emb)?
In regards to stable-diffusion-webui:
Mine parses prompts using their parser.
Mine takes the mean exactly as they do. ComfyUI_ADV_CLIP_emb probably takes the correct mean but hey, this is for the purpose of reproducible images.

But still I think something might be wrong with the A1111 parser.

shiimizu commented 11 months ago

That's because you had use_old_emphasis_implementation turned on. Right click the node for the show/hide menu option and look for the widget. You can also recreate the node and it should work fine. Make sure you've updated because I recently fixed some embedding issues (https://github.com/shiimizu/ComfyUI_smZNodes/commit/2242d4bc1bd3e5f5a392d8828ae533bcfc1fd11e, https://github.com/shiimizu/ComfyUI_smZNodes/commit/554e3f78cc0e435345de1804ffa8b45698425d1b).