shijingsh / react-native-customized-image-picker

iOS/Android image picker with support for camera, video compression, multiple images and cropping
245 stars 59 forks source link

Can't change ALL default language to English. #23

Closed ducpt2 closed 6 years ago

ducpt2 commented 6 years ago

Two tag not work is: //[string name="gallery_image_selected"]Selected[/string] //[string name="gallery_image_unit"]pictures[/string] Sorry i replace < with [ to show. It's still base on Chinese language, any help?Thanks.

liukefu2050 commented 6 years ago

ok,I will checked next add an option for language

ducpt2 commented 6 years ago

I think add gallery_strings.xml is good enough(because i want to add my own language), but don't know why two field is not working. Maybe you can take a look? :) Thank you @liukefu2050 . Have a nice day.

liukefu2050 commented 6 years ago

Do you want to add a new language, not English or Chinese?What language?

ducpt2 commented 6 years ago

I can add my own language using gallery_strings.xml file, no need to add more option language. I need to fix two field: //[string name="gallery_image_selected"]Selected[/string] //[string name="gallery_image_unit"]pictures[/string] I don't know why when i change, it still chinese language? some bug? Please just need take a look at that two field. No need to add new language. Many thank @liukefu2050 .

liukefu2050 commented 6 years ago

I add the "gallery_strings.xml" file to the directory "example\android\app\src\main\res\values" and run react-native run-android, and the language has changed ! How to reproduce your problems It's a good idea to add the "gallery_strings.xml" file!

ducpt2 commented 6 years ago

Are you sure? i use "react-native-customized-image-picker": "0.0.33", and this issues is: 6bc542ec-faa8-11e6-9344-2673c68b49c9 a2cf015c-faa7-11e6-84df-b4dff41ba78e

that mean two field not working: //[string name="gallery_image_selected"]Selected[/string] //[string name="gallery_image_unit"]pictures[/string] @liukefu2050 any suggest? Thanks.

liukefu2050 commented 6 years ago

I fixed it Please use the latest version thanks!

ducpt2 commented 6 years ago

@liukefu2050 love it.