shikha-16 / Women-in-Technology

A collection of resources for women in tech, consisting of - courses, learning guides, amazing sites and repos, blogs, programs and events. scholarships, etc.

https://women-in-technology-wit.web.app/

MIT License

716 stars 159 forks source link

links change according to theme color #174

Closed sungod12 closed 3 years ago

sungod12 commented 3 years ago

Pull Request Template

Description

-Changed link colors to black and white in order to be visible in light and dark mode as per requirements.

Fixes # 142

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My contribution follows the style guidelines of this project
[x] I have performed a self-review of my own contribution
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have checked my code and corrected any misspellings

sungod12 commented 3 years ago

Please review and let me know @nehakalbande.

nehakalbande commented 3 years ago

Please review and let me know @nehakalbande.

There is conflict in event.js file. Please check

sungod12 commented 3 years ago

check now.

shikha-16 commented 3 years ago

Okay, merging

sungod12 commented 3 years ago

Thanks @shikha-16 .Let me know if any issue occurs after merging. Does your site support on the go deploying as in deploy site with new changes after each merge.?

nehakalbande commented 3 years ago

Screenshot (71)

shikha-16 commented 3 years ago

There was some error after we accepted your PR, please check if it's working properly and only then create a new PR @sungod12 Marking this one invalid

sungod12 commented 3 years ago

okay.My bad.I will remember that next time.

shikha-16 commented 3 years ago

@sungod12 these changes ka PR again, after pulling the repo to your local machine, and checking for errors before making the PR

sungod12 commented 3 years ago

okay, check for error by checking for new code and then create new pr for same right?