Adding events description to readme and event/program page

shikha-16 / Women-in-Technology

A collection of resources for women in tech, consisting of - courses, learning guides, amazing sites and repos, blogs, programs and events. scholarships, etc.

https://women-in-technology-wit.web.app/

MIT License

715 stars 159 forks source link

Adding events description to readme and event/program page #180

Open Jayita10 opened 2 years ago

Jayita10 commented 2 years ago

Fixes #130

Type of change

Checklist:

[ ] My contribution follows the style guidelines of this project
[ ] I have performed a self-review of my own contribution
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have checked my code and corrected any misspellings

Jayita10 commented 2 years ago

For adding description in event page, do I need to modify eventlist.js?

nehakalbande commented 2 years ago

For adding description in event page, do I need to modify eventlist.js?

Modify eventlist.js and modify the cards in event.js

shikha-16 commented 2 years ago

For adding description in event page, do I need to modify eventlist.js?

Yes, pull the repo, because some changes have been made and add the description in the cards

shikha-16 commented 2 years ago

did you put the descriptions? is this ready to merge? @Jayita10

Jayita10 commented 2 years ago

did you put the descriptions? is this ready to merge? @Jayita10

Please wait for 2 more days! I am little busy with college work, Thanks!

shikha-16 commented 2 years ago

did you put the descriptions? is this ready to merge? @Jayita10

Please wait for 2 more days! I am little busy with college work, Thanks!

okay no problem, lmk when its ready to merge!

Jayita10 commented 2 years ago

https://github.com/shikha-16/Women-in-Technology/blob/6c0cdb18d60723f837e5a8e4b8cca328e992d1c7/website/src/pages/events.js#L43

<Typography paragraph variant="h5" component="h2">
           {a.description}
</Typography>

Here I am thinking of using paragraph , Will it be okay? Actually I haven't much knowledge on meterial ui and typography, so asking for conformation!

@shikha-16

nehakalbande commented 2 years ago

https://github.com/shikha-16/Women-in-Technology/blob/6c0cdb18d60723f837e5a8e4b8cca328e992d1c7/website/src/pages/events.js#L43
<Typography paragraph variant="h5" component="h2">
           {a.description}
</Typography>
Here I am thinking of using paragraph , Will it be okay? Actually I haven't much knowledge on meterial ui and typography, so asking for conformation!

@shikha-16

Hi @Jayita10 Please have a look at Material UI Components, since there components are responsive and looks good. With p tag you'll need to more css.

shikha-16 commented 2 years ago

@Jayita10 whats the status on this?

Jayita10 commented 2 years ago

Please review @shikha-16 @nehakalbande

shikha-16 commented 2 years ago

Okay @Jayita10 can u attach a screenshot of how it looks on the website?

shikha-16 commented 2 years ago

Okay @Jayita10 can u attach a screenshot of how it looks on the website?

@Jayita10

shikha-16 commented 2 years ago

hi @Jayita10 can you please respond as soon as possible. thanks