shikha-16 / Women-in-Technology

A collection of resources for women in tech, consisting of - courses, learning guides, amazing sites and repos, blogs, programs and events. scholarships, etc.

https://women-in-technology-wit.web.app/

MIT License

715 stars 159 forks source link

Remade Cards and Study Resource Page #185

Closed madhhuurrii closed 2 years ago

madhhuurrii commented 2 years ago

Pull Request Template

Description

Created Study Resource Page and Remade cards in the page.

Fixes #139

Type of change

Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My contribution follows the style guidelines of this project
[x] I have performed a self-review of my own contribution
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have checked my code and corrected any misspellings

studyresource

shikha-16 commented 2 years ago

Hi @madhhuurrii, just see these conflicting files and resolve the conflicts please. We merged another PR so it had to happen.

madhhuurrii commented 2 years ago

Hi @madhhuurrii, just see these conflicting files and resolve the conflicts please. We merged another PR so it had to happen.

Yes will do!

shikha-16 commented 2 years ago

@madhhuurrii so sorry for the inconvenience, please look at 1 more conflict, and i will merge yours next!

madhhuurrii commented 2 years ago

Hii, I haven't finalised the changes after resolving the previous conflicts , will let you know once I fix all changes!

madhhuurrii commented 2 years ago

Hii @shikha-16 @nehakalbande , I have finished editing all the changes! Please review the PR :) The Final page now looks like this. studyresource final

shikha-16 commented 2 years ago

Hii @shikha-16 @nehakalbande , I have finished editing all the changes! Please review the PR :) The Final page now looks like this.

Hey @madhhuurrii !! This looks good :) two things,

Can you make the fonts everywhere the same size, and consistent with the rest of the website?
The image sizes don't look that good, can you fix that please?

madhhuurrii commented 2 years ago

Hii @shikha-16 , I have made the required changes, Please look into it studyresource

nehakalbande commented 2 years ago

Hii @shikha-16 , I have made the required changes, Please look into it

Hi @madhhuurrii Footer icons doesnt seem responsive in the ss. Please have a look over it..

madhhuurrii commented 2 years ago

Hi @madhhuurrii Footer icons doesnt seem responsive in the ss. Please have a look over it..

I didn't tried modifying the footer components, I don't know what is causing it, will look into it! Edit : I have fixed the issue!

shikha-16 commented 2 years ago

Okay great! I'm merging this now :)