Closed umang-sinha closed 3 years ago
i would like to work on this one, @umang-sinha what do you think about adding material-ui to the project?
Yes we are planning to go with material UI
please assign this issue to me.
@greyGroot I am assigning this to you. You can go ahead and start working on it.
@greyGroot , I'm emphasizing this again, you do NOT have to code for the carousel, somebody else is already working on that. Focus on the other parts and leave the carousel.
@greyGroot i need some response from you
@shikha-16 I'm working on it
@shikha-16 I'm working on it
okay, you can refer to https://github.com/shikha-16/Women-in-Technology/issues/56 comments for the same. We are looking for something exactly like that.
@shikha-16 as i see in pr #63 he was using bootstrap, but i thought you want to add Material-UI. So what approach should i use?
Hi @greyGroot @shikha-16 thanks for mentioning the issue. Personally, I think we need to decide the framework and I'm okay if we want to use material UI or any css framework.
I was only focused on the skeleton of my page. But since the main components like navbar, carousel, and footer are missing, I took faster approach to work around that using bootstrap.
I'm happy to work on the update if we use another framework
@syauqy thank you for your contribution and happy to see that you ready to make update.
personally, i love to work with react material ui, but we can go with bootstrap, because Navigation, Footer and Carousel is ready.
@shikha-16 should i do it with bootstrap? or we need to update #63 with material ui ?
Personally, I prefer material ui as well. I will wait for the decision to start working in the contribution page.
Instead of getting into the hassle of updating #63 with material ui we should just proceed with bootstrap to make progress faster.
@umang-sinha there is small inconsistency in design of "Founder" block:
this option is from figma, home-page:
and this one from Community page:
maybe we should align those two components?
@shikha-16 regarding carousel. @syauqy implemented main carousel, but we also have smaller one with cards, like here:
and here:
Should i implement it, or somebody is working on it?
@greyGroot nobody is working on those. Can you please implement it? You can use the code made by him as reference!
hey @greyGroot any updates on the issue?
@umang-sinha i was busy last few days, but now i'm working on it. it's in progress.
Have you made a decision regarding "About Founder" block?
@umang-sinha i was busy last few days, but now i'm working on it. it's in progress.
Have you made a decision regarding "About Founder" block?
yes please go ahead with the one on the home page
@umang-sinha i'm working on carousel for cards, and i'm facing some troubles.
Here how it looks at the moment: https://youtu.be/z6_7aDI8xVE
On a design we have only one control on the right side. If user will click it, he should see next 4 cards, right? How many slides there should be? Or how many cards in total? If user will click on the right control, how he will be able to turn back to the first slide?
And as i see, there should be less cards on one slide on smaller screens, right?
@umang-sinha i'm working on carousel for cards, and i'm facing some troubles.
Here how it looks at the moment: https://youtu.be/z6_7aDI8xVE
On a design we have only one control on the right side. If user will click it, he should see next 4 cards, right? How many slides there should be? Or how many cards in total? If user will click on the right control, how he will be able to turn back to the first slide?
I guess that is an inconsistency that was missed while making the wireframes. To tackle this lets enable horizontal scrolling in those slides. When the users scrolls down they will move towards the rightmost slide and vice versa. Regarding the total number of slides, I don't think I have a fixed number in mind. That depends on the amount of content we have to display. For now just create 6-7 slides to get the gist of how it will actually look when implemented.
And as i see, there should be less cards on one slide on smaller screens, right?
Yes. Try to make it responsive to smaller screens using media query or any other means
@umang-sinha ok, then i will add control on the left side of slider and i will reduce amount of cards according to table size.
@greyGroot updates? when will you be done by?
@shikha-16 i will have time to work on this one only on the weekends
@shikha-16 i will have time to work on this one only on the weekends
Please set a deadline so that you are motivated to work, and we have something to work with as well. @greyGroot
Contributors interested in working on the home page for the website can take up this issue. You can have a look at the wireframes here.
The homepage needs to have the following components:
Contributors are requested to strictly adhere to the format followed in the wireframes. Please go through Contributing.md and the basic skeleton before contributing.
Also join the Discord server so that communication can be done smoothly.
For an overview of the project, see here