netlify[bot]
commented
3 months ago Deploy Preview for shiki-matsu ready!
| Name | Link |
|---|---|
| Latest commit | b3218e97c968178b2fa5ed36747cc9c8f6ae2f64 |
| Latest deploy log | https://app.netlify.com/sites/shiki-matsu/deploys/66bce8a1c55c27000807e719 |
| Deploy Preview | https://deploy-preview-729--shiki-matsu.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
codecov[bot]
Description
Trim the single trailing newline at the end of code that gets passed into Shiki from Rehype, which would result in dangling empty
<span class="line">elements at the end of every code block.Usually, these extra elements aren't an issue—evident by the fact that this appears to mostly have flown under the radar since the Rehype plugin was introduced, the only instance I can find of someone noticing this is in a comment on an unrelated issue—however this issue emerges if you wish to display line numbers within a code block using a CSS counter, which my website does.
Linked Issues
Additional context
This fix only trims the very last newline, as that's the problem one that is received by Shiki from Rehype. I'm assuming that any extra newlines within the code block are the user's own fault (intentional or not), so they probably shouldn't be messed with.