search

shikijs / textmate-grammars-themes

Collection of TextMate grammars and themes in JSON
https://textmate-grammars-themes.netlify.app/
MIT License
116 stars 57 forks source link

fix: Use Valid Hexcode For Monaco Editor Integration #35

Closed hiddenest closed 9 months ago

hiddenest commented 9 months ago

Linked Issues

shikijs/shiki#594

Summary

Format 3, 4 letter shortcut hexcodes into valid format:

netlify[bot] commented 9 months ago

Deploy Preview for textmate-grammars-themes ready!

Name Link
Latest commit b8236a7e9d2c925c7b7095c2d2d71f7d902b1e8a
Latest deploy log https://app.netlify.com/sites/textmate-grammars-themes/deploys/65d203a0f80afa00085c8b42
Deploy Preview https://deploy-preview-35--textmate-grammars-themes.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

antfu commented 9 months ago

Those files are generated, modifying them directly won't save them to the next release.

While we could normalize the color on fetch, since this is only for Monaco-specific integration, I think it could be fixed in the theme conversion logic.

https://github.com/shikijs/shiki/blob/8f9be6caf577382b90adc51d4a40a707b2ec292b/packages/monaco/src/index.ts#L83-L85

Feel free to open an issue in Shiki's repo, or better directly a PR fixing it. Thanks.