search

shikijs / textmate-grammars-themes

Collection of TextMate grammars and themes in JSON
https://textmate-grammars-themes.netlify.app/
MIT License
116 stars 57 forks source link

fix: add code transformers support for the `rose-pine` theme #82

Closed lzl0304 closed 3 months ago

lzl0304 commented 3 months ago

fixes https://github.com/shikijs/shiki/issues/730

netlify[bot] commented 3 months ago

Deploy Preview for textmate-grammars-themes ready!

Name Link
Latest commit beed4f9b0c808ca47132749d8a0b241c28c7ccb1
Latest deploy log https://app.netlify.com/sites/textmate-grammars-themes/deploys/66b3147865885c00079e566f
Deploy Preview https://deploy-preview-82--textmate-grammars-themes.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

antfu commented 3 months ago

Thank you, but we couldn't just patch the themes, as they are synced with upstream and will get overridden. It's more like something on the shiki transformer side to support it.

lzl0304 commented 3 months ago

Thank you, but we couldn't just patch the themes, as they are synced with upstream and will get overridden. It's more like something on the shiki transformer side to support it.

I didn't notice that I needed to synchronize from upstream; I was thinking too simply.

davidwarrington commented 2 months ago

@lzl0304 did you open a PR/issue for the Rose Pine VSCode theme at all? I've patched my current shikijs install with your fix (thank you so much btw), but keen to see this get resolved properly. Unfortunately I don't know enough about why your fix works to open this PR myself.