Closed arcanis closed 1 year ago
Latest commit: bfca2ac90927ccd78cf274ee3151241fec21641e
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
I think if you run node scripts/syncVersion.js
it should clear up that GA fail - otherwise looks good to me and makes sense
Thanks
OK, those are deployed ππ»
Due to the
ReturnType
use here, the generated types forshiki-twoslash
include a reference tofenceparser
, which should then be in thedependencies
listing.Similarly, the
import 'unist'
here doesn't work out-of-the-box since@types/unist
isn't listed in the dependencies (of note, theunist
package doesn't exist, only@types/unist
does).Since the intent is probably to use whatever TS version the consumer uses,
typescript
should be a peer dependency rather than a regular dependency (otherwise there's a chance some hoisting mess will happen, especially if the user happens to use a prerelease TS build, which won't semver-match the>
predicate).Fixes the following errors: