shiksha-platform / frontend-modulefederation

The frontend repo includes configurable UI components, modules and apps to create the Shiksha experience
10 stars 58 forks source link

Attendance module - Visual Design on Mark all as Present needs review #46

Open SaketSinha opened 2 years ago

SaketSinha commented 2 years ago

Description

Attendance module - Visual Design on Mark all as Present needs to be reviewed with the Visual design team.

How to reproduce

Step 1: Go to https://sandbox.shikshaplatform.io/modules/attendance/ Step 2: Login with credentials Step 3: Click on Edit attendance Step 4: Mark all as Present The user can see an animation of action being completed. This visual cue needs to be reviewed with Visual design team.

Screenshots

image image

Versions

Logs

Any logs (if any) generated in

ananya-jain1 commented 2 years ago

Hey @Shravani-MF - can you please have a look at this and add in this week's plan? We will need a visual design for the screen which the user sees after clicking on 'Mark All Present'?

Shravani-MF commented 2 years ago

@ananya-jain1 @SaketSinha -

  1. The button labels and hierarchy are mixed. The buttons are - Mark all Present (Secondary) & Submit (Primary). link to design: https://www.figma.com/file/oFy6JKC4V0v1t26ZedMLd4/Shiksha-App-Dev-file?node-id=752%3A2920
  2. When the user clicks on Mark all Present, all the student's circles for today's date will turn green with a tick. Also the button will turn into 'UnMark All'.

If we need visual screens for this we can provide those, not a problem.

ananya-jain1 commented 2 years ago

Hey @Shravani-MF we are talking about the second screen attached in the comment. Where there is a loading button with text 1 already present.

image

Shravani-MF commented 2 years ago

@ananya-jain1 @sagarkoshti1990 Here you go: https://www.figma.com/file/oFy6JKC4V0v1t26ZedMLd4/Shiksha-App-Dev-file?node-id=2510%3A58113. This has the loader screen visual.

Shravani-MF commented 2 years ago

@ananya-jain1 This screen is updated with the content on the same link