search

shilangyu / scoop-search

Fast `scoop search` drop-in replacement 🚀
MIT License
289 stars 10 forks source link

Push Binary #61

Closed skanda890 closed 4 months ago

skanda890 commented 4 months ago 
          Unfortunately, I do not understand and you are not telling me why this is being done. Feel free to open an issue instead, I will be happy to help.

Originally posted by @shilangyu in https://github.com/shilangyu/scoop-search/issues/60#issuecomment-2214253497

skanda890 commented 4 months ago

Re-open #60

shilangyu commented 4 months ago

@skanda890 please tell me why this is needed. Releases of scoop-search include binaries. https://github.com/shilangyu/scoop-search/releases/tag/v1.5.0

skanda890 commented 4 months ago

First, when I wanted to merge branches I went to skanda890/scoop-search and found two branches named feat/debug-logging and one more branch, merged them into the default branch, and created #57 then you closed it saying that the base branch has been updated, etc, and I created #60 and since Debug Logging was already fixed we remain with only Pushing Binary, and that is why I wanted to merge #60.

skanda890 commented 4 months ago

I am creating one more pull request, as you saw my explanation please allow to merge that pull request.

shilangyu commented 4 months ago

But why is the binary being pushed?

skanda890 commented 4 months ago

3cc79301528041287d367475a5e722f1fd1c3ddf

shilangyu commented 4 months ago

Closing due to no direct response to my question. Feel free to comment with an answer and I will be happy to help.

skanda890 commented 4 months ago

@shilangyu, in https://github.com/shilangyu/scoop-search/commit/3cc79301528041287d367475a5e722f1fd1c3ddf, we see that you have called it Push Binary and that is why I am pushing the binary code, so please re-open #60.