Closed rikbrown closed 3 years ago
C'mon based Quant man @shilewenuw, MERRRRRGGGEEEEEEE
wow I waited so long for an approval and now you're begging for a merge? fair. PLEASE GIVE.
If we don't get a merge by next week we can consider this dead and I'll just make an "official" fork.
Alas, @rikbrown, it appears the based QUANT man @shilewenuw is MIA.
TBH I didn't pay much attention to this project b/c I thought Nasdaq implemented measures that killed this library, so I'm surprised that this can still work after changes. Anyways, @rikbrown is now a collaborator (once he accepts the invite).
@shilewenuw thank you for making this project and for making @rikbrown a collaborator!
Background
See https://github.com/shilewenuw/get_all_tickers/issues/15
Change
Credit to @JaisinhBhosale9712 and others in that thread who figured out the fix - this is just a PR incorporating their changes (and cleaning up some debug-ey code in those changes as well). See the above issue for discussion.
Testing
Used
get_all_tickers
locally and now it works.