shilewenuw / get_all_tickers

Get all publicly traded tickers with this library

MIT License

275 stars 124 forks source link

Fix "Error tokenizing data" from get_tickers caused by Nasdaq API change #17

Closed rikbrown closed 3 years ago

rikbrown commented 3 years ago

Background

See https://github.com/shilewenuw/get_all_tickers/issues/15

Change

Credit to @JaisinhBhosale9712 and others in that thread who figured out the fix - this is just a PR incorporating their changes (and cleaning up some debug-ey code in those changes as well). See the above issue for discussion.

Testing

Used get_all_tickers locally and now it works.

uriscoes commented 3 years ago

C'mon based Quant man @shilewenuw, MERRRRRGGGEEEEEEE

rikbrown commented 3 years ago

wow I waited so long for an approval and now you're begging for a merge? fair. PLEASE GIVE.

rikbrown commented 3 years ago

If we don't get a merge by next week we can consider this dead and I'll just make an "official" fork.

uriscoes commented 3 years ago

Alas, @rikbrown, it appears the based QUANT man @shilewenuw is MIA.

shilewenuw commented 3 years ago

TBH I didn't pay much attention to this project b/c I thought Nasdaq implemented measures that killed this library, so I'm surprised that this can still work after changes. Anyways, @rikbrown is now a collaborator (once he accepts the invite).

uriscoes commented 3 years ago

@shilewenuw thank you for making this project and for making @rikbrown a collaborator!