search

shilomagen / passport-extension

MIT License
131 stars 23 forks source link

npm ci fails #5

Closed alongalky closed 1 year ago

alongalky commented 1 year ago

Context

I'm trying to run the code locally. I cloned the repo, ran npm ci, and got an error.

I tried several versions of Node.js (14, 16, 18). This is possibly related to #2 , since it's very possible I'm missing a setup step.

Expected Behavior

npm ci or npm install should install successfully.

Current Behavior

Fails with an error:

$ npm ci
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: awesome-typescript-loader@5.2.1
npm ERR! Found: typescript@4.5.4
npm ERR! node_modules/typescript
npm ERR!   dev typescript@"^4.0.3" from the root project
npm ERR!   peer typescript@">= 2.7" from fork-ts-checker-webpack-plugin@6.5.0
npm ERR!   node_modules/@storybook/builder-webpack5/node_modules/fork-ts-checker-webpack-plugin
npm ERR!     fork-ts-checker-webpack-plugin@"^6.0.4" from @storybook/builder-webpack5@6.4.9
npm ERR!     node_modules/@storybook/builder-webpack5
npm ERR!       dev @storybook/builder-webpack5@"^6.4.9" from the root project
npm ERR!       2 more (@storybook/core, @storybook/core-server)
npm ERR!   6 more (fork-ts-checker-webpack-plugin, ...)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer typescript@"^2.7 || ^3" from awesome-typescript-loader@5.2.1
npm ERR! node_modules/awesome-typescript-loader
npm ERR!   dev awesome-typescript-loader@"^5.2.1" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: typescript@3.9.10
npm ERR! node_modules/typescript
npm ERR!   peer typescript@"^2.7 || ^3" from awesome-typescript-loader@5.2.1
npm ERR!   node_modules/awesome-typescript-loader
npm ERR!     dev awesome-typescript-loader@"^5.2.1" from the root project
shilomagen commented 1 year ago

Resolved by https://github.com/shilomagen/passport-extension/pull/8