search

shilow / boar

Automatically exported from code.google.com/p/boar
https://bitbucket.org/mats_ekberg/boar/wiki/Home
0 stars 0 forks source link

Show progress when commit #101

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Commit a lot of files

What is the expected output? What do you see instead?
I just realize that when committing a lot of files there's no progress 
indicator. Adding [completed files / total files], elapsed time, remaining time 
, is really a huge UI improvement, and technically trivial.
Some VCS doesn't have this feature, but you don't commit thousands of files 
with them, which is a pretty common usecase for Boar.

Original issue reported on code.google.com by uts...@gmail.com on 17 Aug 2013 at 3:36

GoogleCodeExporter commented 8 years ago 
Yes, progress during commit is highly desirable. A commit is a three stage 
process. Initial scan of the files on the client, sending the files to the 
server and a final server-side verification of the data. Only the final step is 
lacking progress information, but that is bad enough, as it can be quite 
lengthy. 

Unfortunately, it is not exactly trivial to add this feature. The boar client 
performs a RPC call to the server which triggers the final stage, and the call 
does not return until the commit is complete. Just adding a suitable "print" in 
the server code would be trivial, but that would only be visible when accessing 
a local repository (not to mention violating all rules regarding code 
separation). But it will get fixed somehow.

Original comment by ekb...@gmail.com on 20 Aug 2013 at 10:36

GoogleCodeExporter commented 8 years ago 
oh sorry I missed that code separation rules. Glad to hear you're working on it.

Original comment by uts...@gmail.com on 22 Aug 2013 at 4:49

GoogleCodeExporter commented 8 years ago 
Implemented a progress display with spinner that shows file upload and commit 
progress. Required some changes in the network protocol, so the protocol number 
has been increased (that is, it's not backwards compatible).

Original comment by ekb...@gmail.com on 22 Sep 2013 at 8:03

GoogleCodeExporter commented 8 years ago 
Issue 113 has been merged into this issue.

Original comment by ekb...@gmail.com on 1 Apr 2015 at 9:25