Add config to item, so we could change ratio property

shima11 / FlexiblePageControl

A flexible UIPageControl like Instagram.

MIT License

797 stars 108 forks source link

Add config to item, so we could change ratio property #31

Closed odisei369 closed 5 years ago

odisei369 commented 5 years ago

Now, there is no way to change smallDotSizeRatio or mediumDotSizeRatio, because FlexiblePageControl doesn't pass it to underlying ItemView. We also couldn't set it manually, because ItemConfig is private class inside FlexiblePageControl.

So, I fix this problem by creating item config during update and passing it to items. It will work properly in both situation when we set config manually or initialise FlexiblePageControl with config.

shima11 commented 5 years ago

@odisei369 Thank you for your PR !! I think also need this.