search

shime / livedown

Live Markdown previews for your favorite editor.
MIT License
765 stars 51 forks source link

Proposal: add mermaid support #47

Open aigjermo opened 5 years ago

aigjermo commented 5 years ago

Solves #34.

This is just the bare minimum to get it working, I haven't added any config options to opt out or anything like that.

eastwood commented 5 years ago

This is a decent PR. I actually just came here to implement this and was happy to see that someone beat me to it. previm supports mermaid by default and without config options as well. This would be nice to see in master

titanism commented 8 months ago

Can we please have this merged and released to npm @shime ?

titanism commented 8 months ago

Actually this PR is broken. It does not work.

The reason why is because https://github.com/shime/livedown/commit/0e8b97f42fdb9d7a3fc38618fd82e9e1642037c7#diff-2f062de8635f61fbec7693ba8f7bdc5dd196f7e694240826c4b304a1e83baff3 is referencing a file path. You cannot do this. The actual file must be included, similar to Zepto.

@shime if you give me PR/GitHub/npm access we will fix this properly.