search

shime / play-sound

Play sounds by shelling out to one of the available audio players.
MIT License
207 stars 31 forks source link

Adding support for player args and returning the process #17

Closed jjgonecrypto closed 7 years ago

jjgonecrypto commented 7 years ago

Two things:

  1. Player args. This way, the user can supply optional arguments per player via { afplay: ['-v', 1] } (to control volume)
  2. Return child_process. This way the user can issue a kill() if they want to end early
shime commented 7 years ago

Looks good. Could you add this to the readme too?

shime commented 7 years ago

Added you as a collaborator here and on NPM. This is good to merge once we have it in the README and the tests are fixed.

jjgonecrypto commented 7 years ago

@shime would you mind bumping to 1.1.0 and npm publish?

shime commented 7 years ago

🎉 bumped, thank you! You should have permissions to bump versions and npm publish too. I prefer to do it with np.