search

shime / play-sound

Play sounds by shelling out to one of the available audio players.
MIT License
207 stars 31 forks source link

use child_process.spawn #21

Closed Ineluki closed 6 years ago

Ineluki commented 7 years ago

switched to child_process.spawn instead of exec to avoid https://github.com/shime/play-sound/issues/12

had to update the tests for node 8.4

the last two are still not working (some problem with mock-fs that I cannot diagnose right now)

alexbjorlig commented 6 years ago

Hi @shime - It's probably easier to continue the conversation here :)

I would like to try to fix this - but still learning node. I am using the project on raspberry pi's - and this max buffer is giving a lot of issues.