search

shime / vim-livedown

Vim plugin for Livedown.
493 stars 19 forks source link

Fix OSX no longer opening pages in browser #23

Closed cdosborn closed 8 years ago

cdosborn commented 8 years ago

Bug:

g:livedown_browser = "firefox" is the default. This translates to a node exec firefox <url> in livedown. On OSX firefox is not on the path.

Solution:

g:livedown_browser is unset by default. The --browser flag is not passed. The system launcher (ex. open on OSX), is used to open the url.

Commentary:

livedown has the assumption that --browser is optional, when it's not provided, it uses the system's launcher (ex. open on OSX). vim-livedown should be the same way.

Disclaimer: I did not test on linux or windows. I did test on OSX including what was added to the documentation.

cdosborn commented 8 years ago

welp this duplicates #22, but I've extended the documentation.

shime commented 8 years ago

Thanks!