search

shimmerproject / Greybird

Desktop Suite for Xfce
https://shimmerproject.org
Other
415 stars 74 forks source link

Add more gnome-shell theming #199

Open Feichtmeier opened 7 years ago

Feichtmeier commented 7 years ago

Hi and sorry for stealing your time again! :dancing_men: I think there is a little color difference between the blue selection in gnome shell and the blue selection in GTK apps. I didn't want to open an issue for every detail I would like to request so here is more: Would it be possible to have the same beautiful sliders you've added in GTK3 apps in gnome shell? And would it be possible to ave a little transluency in the indicator applet (like my incredible bad GIMP skills show =))? Best regards! screenshot from 2017-07-13 20-12-15 screenshot from 2017-07-13 20-21-46

ochosi commented 7 years ago

Ah alright, yeah that's sort of a known problem. What you see is the dark variant of Greybird in action and I haven't spent much time on it so there is still a lot to be done and fixed - amongst others the shade of blue is slightly different (also to make it a little less "agressive" than in the bright version).

I haven't really given this much time and thought - also I don't have many apps that request the dark variant to play with, so I guess this is - as you correctly inferred - a bigger issue.

I'll rename the title for clarity.

ochosi commented 7 years ago

Ok, I've taken another look and this does not seem to be related to the dark version of the theme (at least not all of it).

The selected background color is a little darker and that is to go along more smoothly with the dark color scheme. I'm not yet sure I will change that to match the bright version.

With respect to the gnome-shell menus and their elements (like GtkSwitch, which you pointed out) I'm starting to wonder whether that is a lack of gnome-shell theming on Greybird's side. I guess I happily accept patches, but I really don't want to start to maintain gnome-shell theming when I don't even use it and can test it...

ochosi commented 7 years ago

@Feichtmeier Could you check whether the gnome-shell parts (the menus from the panel) look identical with Adwaita and Greybird?

If that's the case then I guess I need to edit the title of this issue again...

Feichtmeier commented 7 years ago

Yes, it looks identical - greybird and adwaita gnome shell :)

ochosi commented 7 years ago

Hmkay, so it's really gnome-shell specific theming that is missing for these menus.

To be honest I'm not sure I wanna fix that (as pointed out above I couldn't test it even)

Feichtmeier commented 7 years ago

If I will have a little bit more time soon I can try the gnome shell part

Am 24.07.2017 12:21 schrieb "Simon Steinbeiß" notifications@github.com:

Hmkay, so it's really gnome-shell specific theming that is missing for these menus.

To be honest I'm not sure I wanna fix that (as pointed out above I couldn't test it even)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/shimmerproject/Greybird/issues/199#issuecomment-317381007, or mute the thread https://github.com/notifications/unsubscribe-auth/AOno1tppDQgvJMhAoEjQL5sNmn8IllAgks5sRHA3gaJpZM4OXXNY .

ochosi commented 7 years ago

Ok, if you do that please keep the code to a minimum so it's as maintainable as possible.

Feichtmeier commented 6 years ago

@ochosi I've gathered quiet some experience in shell and gtk themein in the Yaru project and could start on this.

Do you still want me to work on this?

ochosi commented 6 years ago

If the code for it is minimal and you are willing to also fix initial bugs that'd be nice!

Again, I won't maintain the gnome-shell side personally, so if something breaks and nobody with g-s is around to look into it and fix it, I'd probably just drop the code again or close the bugs as wontfix.

Feichtmeier commented 6 years ago

I think it will be very minimal. Only the accent color and some assets. Let's see what I come up with and you can test the PR. :)