shimmerproject / Greybird

Desktop Suite for Xfce
https://shimmerproject.org
Other
417 stars 74 forks source link

Geany gtk3 version fixes #217

Open jEsuSdA opened 6 years ago

jEsuSdA commented 6 years ago

Recently, Ubuntu and Debian released a new Geany version compiled using GTK3. I made some fixes for the new appearance. From this: captura de pantalla_2018-02-18_22-25-43

to this: captura de pantalla_2018-02-18_22-25-01

Here the code:

/* Fix for Geany GTK3 version */
#GeanyMainWindow treeview
{
    font-size:90%
}

#GeanyMainWindow notebook
{
    font-size:95%;
    margin:3px 2px 1px 1px;
}

#GeanyMainWindow statusbar
{
    font-size:80%;
    margin:0;
    padding:0;
}

But the text font size works fine with GTK Inspector but it appears no to be used when inserted into gtkcontained.css theme file. Any suggestion?

jEsuSdA commented 6 years ago

I discover the font size GTK Theme configuration is overwritten by Geany Font configuration. So, all is ok. ;)

ochosi commented 6 years ago

I'm not a fan of changing the font size. I can imagine adding the margin (although I'm also not a fan of doing too much application specific fixing, especially of apps I don't use myself because I won't notice when the fixing becomes breaking), I'll install geany and check.

ochosi commented 6 years ago

Hmm, on 17.10 I still get the Gtk2 version of Geany.

@bluesabre As you seem to maintain a PPA with Geany in its Gtk+3 version, what are your thoughts on the above patch?

jEsuSdA commented 6 years ago

@ochosi , the new Geany versions in Debian and Ubuntu are compiled against GTK+3. And maybe you can omit the font-size styles cause they can be changed into Geany configuration dialogs. ;)