shimmerproject / Greybird

Desktop Suite for Xfce
https://shimmerproject.org
Other
422 stars 78 forks source link

Upstream changes from Greybird Geeko #254

Closed pontaoski closed 5 years ago

pontaoski commented 5 years ago

Most notable changes being upstreamed:

m4u9 commented 5 years ago

There is a chance that renaming Greybird to Greybird-Light will make users lose their theme forcing them to reselect it from the settings. This should be tested

bluesabre commented 5 years ago

Thanks for the quick PR! A few notes...

@Mau-G It's possible we can continue with Greybird-Light if we add a symbolic link to Greybird. Otherwise, we might prefer to just have Greybird / Greybird-Dark. Adwaita also follows this pattern, Adwaita / Adwaita-dark.

Unit193 in #shimmer also produced this diff: http://paste.openstack.org/show/XOu4GZH5EyVEzHWtlsYV/

It highlights the loss of the following themes:

ochosi commented 5 years ago

Personally I'd prefer to stick to Greybird / Greybird-dark. Greybird-light suggests that it's something new, which it isn't.

ochosi commented 5 years ago

Also, this PR seems to pull in far too much. We don't want the OpenSUSE palette etc., instead I'd prefer to have a single, clean commit that introduces the meson build.

m4u9 commented 5 years ago

yes let’s start a clean PR. the openSUSE noise is irrelevant in the commits for this

bluesabre commented 5 years ago

Closed, these changes were applied with #256