Closed pontaoski closed 5 years ago
There is a chance that renaming Greybird to Greybird-Light will make users lose their theme forcing them to reselect it from the settings. This should be tested
Thanks for the quick PR! A few notes...
@Mau-G It's possible we can continue with Greybird-Light if we add a symbolic link to Greybird. Otherwise, we might prefer to just have Greybird / Greybird-Dark. Adwaita also follows this pattern, Adwaita / Adwaita-dark.
Unit193 in #shimmer also produced this diff: http://paste.openstack.org/show/XOu4GZH5EyVEzHWtlsYV/
It highlights the loss of the following themes:
Personally I'd prefer to stick to Greybird / Greybird-dark. Greybird-light suggests that it's something new, which it isn't.
Also, this PR seems to pull in far too much. We don't want the OpenSUSE palette etc., instead I'd prefer to have a single, clean commit that introduces the meson build.
yes let’s start a clean PR. the openSUSE noise is irrelevant in the commits for this
Closed, these changes were applied with #256
Most notable changes being upstreamed: