search

shimmerproject / Greybird

Desktop Suite for Xfce
https://shimmerproject.org
Other
422 stars 78 forks source link

Buildsystem ported to meson and added dark theme #256

Closed m4u9 closed 5 years ago

m4u9 commented 5 years ago

Most notable changes being upstreamed:

Following previous feedback, everything is in there except:

bluesabre commented 5 years ago

Thanks for this. I've done a bit of testing and everything seems to work, but there are a few adjustments and notes.

Additionally, when installing I see several instances of this warning. Not sure if it's a problem.

Installing /home/sean/Projects/Code/shimmer/Greybird/dark/xfwm4/top-right-inactive.xpm to /usr/local/share/themes/Greybird-Dark/xfwm4 Warning: trying to copy a symlink that points to a file. This will copy the file, but this will be changed in a future version of Meson to copy the symlink as is. Please update your build definitions so that it will not break when the change happens.

m4u9 commented 5 years ago 
* The Greybird xfce4-notifyd theme should actually default to the dark theme, with Greybird-bright installed separately.

Now it's Greybird and Greybird-Dark which is consistent with the rest. Wouldn't it be better and simpler to make the notification Greybird-Dark default with Greybird and Greybird-Dark themes? That's how we resolved it in openSUSE and would keep the same formula as everywhere else.

* The Greybird plank theme should be installed to share/themes/Greybird/plank. This enables automatically loading when Plank uses the "GTK+" theme. The same theme can also be installed in Greybird-dark.

ok

* Greybird-Accessibility, Greybird-Compact, and Greybird-Dark should be Greybird-accessibility, Greybird-compact, and Greybird-dark respectively. This matches the current theme as well as upstream Adwaita.

ok

Additionally, when installing I see several instances of this warning. Not sure if it's a problem.

Installing /home/sean/Projects/Code/shimmer/Greybird/dark/xfwm4/top-right-inactive.xpm to /usr/local/share/themes/Greybird-Dark/xfwm4 Warning: trying to copy a symlink that points to a file. This will copy the file, but this will be changed in a future version of Meson to copy the symlink as is. Please update your build definitions so that it will not break when the change happens.

I think we can ignore it but let me ask @appadeia

bluesabre commented 5 years ago

Now it's Greybird and Greybird-Dark which is consistent with the rest. Wouldn't it be better and simpler to make the notification Greybird-Dark default with Greybird and Greybird-Dark themes? That's how we resolved it in openSUSE and would keep the same formula as everywhere else.

Normally it would, but Greybird is a "darkish" theme, defined by the light interface with dark panels and notifications. There's not a way to transition existing configurations to a different theme, such as longtime Xubuntu and Debian Greybird users. Currently the Greybird notification theme is dark, with Greybird-bright being the light option.

m4u9 commented 5 years ago

Now it's Greybird and Greybird-Dark which is consistent with the rest. Wouldn't it be better and simpler to make the notification Greybird-Dark default with Greybird and Greybird-Dark themes? That's how we resolved it in openSUSE and would keep the same formula as everywhere else.

Normally it would, but Greybird is a "darkish" theme, defined by the light interface with dark panels and notifications. There's not a way to transition existing configurations to a different theme, such as longtime Xubuntu and Debian Greybird users. Currently the Greybird notification theme is dark, with Greybird-bright being the light option.

Ok, understood. Should not be trouble to fix it and make it like that