shimmerproject / Greybird

Desktop Suite for Xfce
https://shimmerproject.org
Other
421 stars 78 forks source link

Latest Release(s) xfce-notify - colors changed? #315

Closed 0pLuS0 closed 2 years ago

0pLuS0 commented 2 years ago

Hello,

I found online a rpm at a repo for what I believe is an older version you did, greybird-3.22.12-1.

Using xfce4-notifyd-0.6.2, one thing I'm noticing with themes I can find online, the lower right corner of the OSD theme, the right corners aren't round, you can make out slightly, that they have normal straight corners.

I hope you can fix this corner issue I keep running into.

If you look real close, you'll see the different color and straight edges of the bottom right. You might need to download it, so you can zoom it.

right_corner

Here's the greybird-3.22.12-1 theme I found online.

gtk.css.txt

Did you change the colors of the latest version? Here's a screen shot of the theme I found in the Greybird-3.22.15/light directory.

Also with a lot of the themes I am seeing, the Button has a white line across the top, it's not all solid color. The bottom right also has a little bit of a pointed/straight edged corner too, but it's smaller and not as noticeable.

greybird

Thank you very much for your time and consideration in making xfce-notify themes.

ochosi commented 2 years ago

Hi! This is what it looks like with the latest release image

ochosi commented 2 years ago

FWIW if you're using 'Greybird' as your Gtk theme there is no need to set it in xfce4-notifyd, you can just leave it at 'Default'.

0pLuS0 commented 2 years ago

There is no Default I pick the them I want to use, all the names are displayed, not sure what you mean by a Default. Here's a screen shot showing Greybird as I changed the folder name.

Greybird

Here's a the OSD Notification, I placed the cursor below the right corner, notice the bluer looking straight edge? The lower left and upper right are the same, they aren't as noticeable, but if you look closer. I'm assuming that maybe this is a bug with xfce-notify, not rendering perfectly smooth corners?

At least the theme colors are the same now.

notification

ochosi commented 2 years ago

The Default tries to just use the colors/theming options from the currently selected Gtk theme (in Xfce via Appearance Settings). image

0pLuS0 commented 2 years ago

I don't have Default in Slackware, maybe because I compiled this myself, and Default is tied to a precompiled package for a Distro or Xfce.

Anyhow it seems to be working ok now, the colors, but as I pointed out, the corners aren't getting rounded 100% completly smooth.

THANKS

ochosi commented 2 years ago

If you don't use compositing with your window manager the corners won't be rounded because notifyd doesn't use the XShape extension in these cases.

Anyway, closing this as it seems everything in Greybird works as it should.

0pLuS0 commented 2 years ago

I do use compositing, I'm using picom v9.1, even with picom I'm getting this with some themes, but not all of them.

https://github.com/yshui/picom

If you happen to know, or use picom, maybe you could please be so kind, and look over my config settings, if there is something there I missed, I need to enable that effects this?

picom.txt

THANKS

0pLuS0 commented 2 years ago

This is the only section I can think of for picom that effects rounded corners, but I commented it out, and I still see the corner. So I'm not sure what to do with this? Hmm

rounded-corners-exclude = [
  "window_type = 'dock'",
  "window_type = 'desktop'"
];