search

shimmerproject / elementary-xfce

Elementary icons forked from upstream, extended and maintained for Xfce
GNU General Public License v2.0
269 stars 37 forks source link

Focuswriter has no icon for Xfce panel. #133

Open mknepper opened 5 years ago

mknepper commented 5 years ago

Operating System: Xubuntu 18.04.1 LTS Desktop Environment: Xfce 4.12 Affects: Focuswriter

focuswriter

As you can see, there's no icon for the window button in xfce4-panel. I'm not sure how to fix this! The Papirus theme seems to have it figured out, but I like elementary much better. Thanks!

Edit: Mentioned the wrong icon theme and team!

mknepper commented 5 years ago

Found a fix!

Move the 22x22 and 16x16 icons in hicolor to the xfce-elementary directory proper. Basically, we need a 16x16 icon of Focuswriter and a 22x22 Focuswriter icon. Problem solved. :)

Screenshot attached: screenshot_2018-10-31_20-37-11

As you can see above, the icon is now in the proper location. And it works! Result: screenshot_2018-10-31_20-38-23

I might create a pull request or something to add that icon in. Either way, this is the fix:

sudo cp '/usr/share/icons/hicolor/16x16/apps/focuswriter.png' /usr/share/icons/elementary-xfce/apps/16/

It just occurred to me - does elementary-xfce have any icons for Focuswriter?

ochosi commented 5 years ago

Very strange. The expected behaviour is for icons that we don't carry in elementary-xfce to be picked up from the fallback, which is - amongst others - hicolor.

mknepper commented 5 years ago

Interesting! I wonder why it's doing this. Possibly part of the application itself? I contacted the developer, so we'll see. Will you be adding the Focuswriter icon to your set?

ochosi commented 5 years ago

I'd rather not copy icons in, they should be inherited anyway from hicolor. Otherwise they add to the maintenance burden of a theme that is already growing too heavy for me. (Image if the focuswriter people decide to create a new logo/icon, then I need to notice and update my theme. If I do that for a lot of apps, that'll end up being lots of work.)

mknepper commented 5 years ago

That's fair. I'm still unsure why it's not grabbing it form hicolor. If I could help, I would.