search

shimmerproject / elementary-xfce

Elementary icons forked from upstream, extended and maintained for Xfce
GNU General Public License v2.0
274 stars 37 forks source link

Symbolic NetworkManager icon appears disabled #332

Closed bluesabre closed 1 year ago

bluesabre commented 2 years ago

The greyed-out appearance makes it seem like the network is unavailable.

image

If you disable Request symbolic icons, the standard icon looks better.

image

elementary-xfce-icon-theme 0.17-1, Xubuntu 22.10

newhoa commented 2 years ago

The top one is what elementary currently uses. The bottom is (I think) older elementary but used more often for "actively transmitting". I don't think either communicate "Wired Network" very well.

Checking the different icons and locations, it seems the network-wired icons in the theme are inconsistent at different sizes and in different folders here in elementary-xfce.

e-xfce-network-wired1

Out of all these, I think the "connected squares" icon most symbolizes a wired network best. Both Adwaita (left) and Yaru (right) use that symbol:

e-xfce-network-wired-adwaita e-xfce-network-wired-yaru

Thoughts on using this one, or is the up-down arrow symbol preferred?

bluesabre commented 2 years ago

That's a lot of inconsistency! I don't know that I have any one preference, just so long as the result has the panel symbolic icon following the same style as the other panel icons for "active" (e.g. white, filled in)

newhoa commented 1 year ago

I think it turns out the shade of the icon was a bug in the Status Tray plugin (that was hopefully fixed, discussed here)

I still went ahead and made the style changes and submitted the PR, it should look something like this:

e-x-network-new-ex

The "networked computers" icon used for wired network. The up and down arrows will be used for transmit up/down, and the <--> icon was removed. Let me know if you all are okay with that look.

bluesabre commented 1 year ago

I think this looks great!