shimmerproject / elementary-xfce

Elementary icons forked from upstream, extended and maintained for Xfce
GNU General Public License v2.0
269 stars 37 forks source link

Icon open-menu is incorrect at one scale #419

Closed caclark closed 4 months ago

caclark commented 5 months ago

The open-menu icon at scale /16/ is a gear-wheel. All other icons of this name are 3 horizontal bars.

newhoa commented 4 months ago

@caclark, Thanks for the report. I made a fix here if you'd like to check it out and test it. I couldn't actually find an app that uses the plain 16px open-menu icon, if you know of one let me know so I can check how it looks in use.

I also upped the contrast a little and the borders should look sharper in dark themes now.

Only issue is I had to make it slightly off center (1px down) to make it look sharp. I tried using thicker lines which made it center, but just looked worse, so hopefully it looks okay slightly off center.

Let me know if that works okay or you think it needs any tweaking.

caclark commented 4 months ago

I have attached before and after screenshots of the icon in use. I noticed the problem when using Geeqie: https://github.com/BestImageViewer/geeqie

The result is excellent.

Thanks for the work. Screenshot_2024-02-10_17-11-43 Screenshot_2024-02-10_17-39-40