search

shimmerproject / elementary-xfce

Elementary icons forked from upstream, extended and maintained for Xfce
GNU General Public License v2.0
269 stars 37 forks source link

NetworkManager while connected to a VPN icon looks weird in XFCE Panel #433

Closed sudcapitano closed 3 months ago

sudcapitano commented 3 months ago

Same as the title. See the screenshot below. I remember on Xubuntu it shows a big lock icon instead. Not sure why it shows this on Arch.

immagine

You can see it doesn't look right. The small lock icon is not above the Ethernet icon it looks like it is attached and it is not outlined either. It is overlapping, maybe change it to the same one that Xubuntu uses?

newhoa commented 3 months ago

Thanks for reporting!

Ok, this took me a while to figure out since Arch, Xubuntu (and Fedora) all use this same theme. So it's some kind of app or config difference with either the distro or nm-applet.

It looks like Xubuntu/Ubuntu uses a different configuration or installation method of nm-applet? When I check the Xfce panel Status Tray plugin, Network Manager Applet shows as:

When nm-applet shows as a Status Notifier the icon is replaced in every state change (so the "Connecting" animation replaces the Ethernet/Wifi icon, and the full VPN lock icon replaces the Ethernet/Wifi icon).

When nm-applet shows as Systray the Ethernet/Wifi icon always remains and the animations and VPN icons act as emblems and overlap the existing icon.

I'm not sure exactly how to completely fix this on both sides from an icon theme perspective. At the very least the lock emblem could be changed from white to the yellow/orange (it's only white in the "dark" variant). This still doesn't look good when the icon is set to anything less than 24px though since the lock sits on top of the bottom right square.

We have been colorizing non-symbolic icons recently, and since Systray icons are always non-symbolic that might help a little more.

newhoa commented 3 months ago

@sudcapitano See if you can start nm-applet as an indicator. The indicator flag (at launch or build, I'm not sure) seems to be what makes it show as a StatusNotifier in the Xfce Status Tray.

killall nm-applet
nm-applet --indicator

This works on Fedora, so hopefully it will work on Arch. It may require libappindicator-gtk3 for this to work. It's also possible libappindicator-gtk3 might be required to be installed before building/installing network-manager-applet if it looks for that as an optional build flag.

If that works, you should be able to set Status Tray to request symbolic icons, then it will use the large lock symbol like Xubuntu.

sudcapitano commented 3 months ago

Thanks so much, I just tested it and that seems to fix it. I really appreciate your work by the way. Every time I install XFCE I instantly get this icon pack.

newhoa commented 3 months ago

Thanks! Glad it worked out!