search

shimmerproject / elementary-xfce

Elementary icons forked from upstream, extended and maintained for Xfce
GNU General Public License v2.0
274 stars 37 forks source link

Add a new 'x' button for dark themes #449

Open sudcapitano opened 5 months ago

sudcapitano commented 5 months ago

I noticed that the x button (beside "document 1 not saved" in the picture below) could be changed to have different colors when using a dark theme so it doesn't blend in with the background of the window and for easier visibility. This applies to all programs even on XFCE apps like Thunar. Basically with any dark theme it looks like that, even using Greybird-Dark.

immagine Maybe make it a white square with a black x? Reverse the colors or something?

newhoa commented 3 months ago

Thanks for the report and picture/

The plan is to kind of phase out light and dark themes and have icons that work well in both situations.

This square one was kind of a compromise between what we had before (a light X for dark theme and dark X for light theme) and one that works for both themes but wasn't too different from what we had before.

So I don't think going back to separate icons is an ideal solution.

Maybe better solutions would be:

1) Come up with a new and better icon that works better in both light and dark themes without being too "loud" or distracting. 2) Make PRs or raise issues on apps to request they use symbolic icons (this would automatically make the X light on dark themes and vice versa). 3) Force symbolic icons in tab buttons in the Gtk theme.

Xfce already uses the symbolic window-close icon for dialogs and other situations. So I think requesting the symbolic close icon be used for tab close buttons might be an acceptable solution for the app developers.

There are probably apps that would not do that (like MATE apps), so maybe working on a better icon at some point would also be good.

If anyone has good designs/ideas for that feel free to share.

sudcapitano commented 2 months ago

Hi I recently took it upon myself to change the color of the window-close.svg because it had been bothering me for sometime. I am going to attach a screenshot to get your feedback. I didn't want to make it a bright red, so I opted for a darker maroon type of color, that way it will work in both situations and won't be too distracting either. Let me know what you think.
This is in Thunar with a dark theme. immagine window-close

I attached the window-close.svg at the bottom too. I used the elementary color Strawberry 900 7a0000. @newhoa