search

shimmerproject / elementary-xfce

Elementary icons forked from upstream, extended and maintained for Xfce
GNU General Public License v2.0
269 stars 37 forks source link

xfce4-notifyd panel icon #451

Open dmillfree868 opened 2 months ago

dmillfree868 commented 2 months ago

I noticed that the xfce4-notifyd panel icon. Under panel preferences >appearance >fixed icon size. If you toggle that from size 22 and go up when you hit size 24 it is giving you an icon that appears to be size 16, then you go back to 23 and the icon recovers size or go to 25 and the icon recovers size. Manually putting it on 24 gives you an icon that is not 24. If I put my icon theme on Adwaita it does not do this. Screenshot_2024-04-25_03-40-50

newhoa commented 2 months ago

Thanks for the report!

Looks like the 24px icon is just the 16px icon on a 24px page/canvas. Same for Bluetooth.

This is from upstream so I'm guessing they have some purpose for that (we do the same for some icons, like the toolbar icons in Thunar are 24px but are made to look 16px so they aren't too big).

Not sure what the solution should be...

1) Just delete notification-*-symbolic from status/24 and let the 16px symbolic icons scale themselves 2) Make a properly scaled 24px icon (would be ideal since they'd be crisper, and have proper margins. we'd need to do this for all panel icons to be consistent (wifi, ethernet, bluetooth, volume, etc) -- but app tray icons wouldn't so it wouldn't look uniform against most app tray icons) 3) Do nothing and follow upstream

@dmillfree868 For now, the quick solution to make it act like other icons is option 1, just delete the symbolic notification icons from your elementary-xfce/status/24 folder.