search

shimming-toolbox / tissue-to-MRproperty

Assign magnetic resonance property values to segmented anatomy
GNU General Public License v3.0
3 stars 0 forks source link

Add susceptibility values in the table #2

Closed jcohenadad closed 1 week ago

sriosq commented 2 weeks ago

Added the look-up table for the susceptibility values being used, thanks for highliting it @jcohenadad

jcohenadad commented 2 weeks ago

Added the look-up table for the susceptibility values being used

where is this added? always refer to the commit SHA in comments please, otherwise we cannot review

jcohenadad commented 2 weeks ago

i assume this is the commit in question: https://github.com/shimming-toolbox/tissue-to-MRproperty/commit/92e767ecd3b4930f9ddb3692df7b95873949808b

the problem here is that you created another table-- why not simply adding a column only the existing table?

sriosq commented 2 weeks ago

Working on it

sriosq commented 2 weeks ago

I initially had 2 separated tables but now its a new column here: 4de1a893c9ce364a0937832c4c62613784a75b07 Apologies for not directing to it before @jcohenadad

sriosq commented 1 week ago

Task completed. Closing the issue