search

shimohq / react-native-cookie

A cookie manager module for react-native
MIT License
93 stars 49 forks source link

Broken for Android on React-Native v47 #6

Closed fpetitit closed 7 years ago

fpetitit commented 7 years ago

Hi, thank you for the development of this useful library.

After upgrading my project from React-Native 0.46.1 -> 0.47.1, the compilation for Android fails with this error : 

:react-native-cookie:compileReleaseJavaWithJavac - is not incremental (e.g. outputs have 
changed, no previous execution, etc.).
[...]/node_modules/react-native-
cookie/android/src/main/java/im/shimo/react/cookie/CookieManagerPackage.java:27: error: 
method does not override or implement a method from a supertype
    @Override
    ^
Note: [...]/node_modules/react-native-
cookie/android/src/main/java/im/shimo/react/cookie/CookieManagerModule.java uses or
overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
1 error
:react-native-cookie:compileReleaseJavaWithJavac FAILED
fpetitit commented 7 years ago

Documentation about this problem : https://github.com/rebeccahughes/react-native-device-info/issues/197

fpetitit commented 7 years ago

I just opened a PR : https://github.com/shimohq/react-native-cookie/pull/7