search

shimohq / react-native-prompt-android

A polyfill library for Alert.prompt on Android platform, working both on Android and iOS platform.
MIT License
129 stars 74 forks source link

Support React 0.56, android 26 sdk #38

Open koreus7 opened 6 years ago

koreus7 commented 6 years ago

Building with react 0.56 for android produces the folowing build errors:

.../react-native-prompt-android/android/build/intermediates/res/merged/release/values-v24/values-v24.xml:3: AAPT: Error retrieving parent for item: No resource found that matches the given name 'android:TextAppearance.Material.Widget.Button.Borderless.Colored'.

.../react-native-prompt-android/android/build/intermediates/res/merged/release/values-v24/values-v24.xml:4: AAPT: Error retrieving parent for item: No resource found that matches the given name 'android:TextAppearance.Material.Widget.Button.Colored'.

.../react-native-prompt-android/android/build/intermediates/res/merged/release/values-v26/values-v26.xml:15:21-54: AAPT: No resource found that matches the given name: attr 'android:keyboardNavigationCluster'.

.../react-native-prompt-android/android/build/intermediates/res/merged/release/values-v24/values-v24.xml:3: error: Error retrieving parent for item: No resource found that matches the given name 'android:TextAppearance.Material.Widget.Button.Borderless.Colored'.

.../react-native-prompt-android/android/build/intermediates/res/merged/release/values-v24/values-v24.xml:4: error: Error retrieving parent for item: No resource found that matches the given name 'android:TextAppearance.Material.Widget.Button.Colored'.

This is likely due to targeting android 26 sdk which is now required for play store submission https://github.com/react-native-community/react-native-releases/blob/master/CHANGELOG.md#056

This means no app can go into production using this widget as it stands undtil this is resolved.

My Environment

OS: macOS High Sierra 10.13.4
Node: 10.5.0 - /usr/local/bin/node
Yarn: 1.7.0 - /usr/local/bin/yarn
npm: 6.1.0 - /usr/local/bin/npm
Watchman: 4.9.0 - /opt/local/bin/watchman
npmPackages:
  react: 16.3.1 => 16.3.1
  react-native: 0.56.0 => 0.56.0

Thanks.

Subway19 commented 5 years ago

We need to resolve this soon. Please provide update

marcelschulze commented 5 years ago

@Subway19 @koreus7 did you find any solution to this problem? I do not find any other alternative library... its such a basic thing, I don't understand why this is not implemented in react native since forever...

rosskhanas commented 5 years ago

@marcelschulze a https://github.com/shimohq/react-native-prompt-android/pull/37 was merged and published to NPM so it works now, I think this issue can be closed.

marcelschulze commented 5 years ago

@rtkhanas Oh, I see. Sorry I didn't realise that I never did build android production before, after I did upgrade to the newest react-native version. So it is related to some different package and not this one, I also did just install recently. So we can close it