search

shimupan / lineupx

A Free Lineup Database for a Variety of Games
https://lineupx.net
MIT License
21 stars 0 forks source link

[bug fix] Preview for each post shows on hover #338

Closed gorDaChris closed 1 month ago

gorDaChris commented 1 month ago

The original bug was no preview being shown when the user hovers over a post. This is what a preview looks like now: commit1

The issue was coming from the image url, since we were appending the Cloudinary string to current image string. I found that 'f_auto,q_auto' was being appended in addition to the current image string, which was giving an invalid URL. I removed 'f_auto,q_auto', and images were able to be displayed again because the image url is no longer invalid. Since I deleted something, I traced back when it was changed - commit 294. From further inspection, nothing significant was reliant on this change, and so deleting it was safe.

shimupan commented 1 month ago

Looks good! I would wait to merge this into main because someone else is currently working on this file. Gotta make sure there's no merge errors.

shimupan commented 1 month ago

Well actually, there was not much change so feel free to merge whenever!